netdev - Re: [PATCH 1/3] dt-bindings: net: ti,cc1352p7: Add boot-gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240722-system-judge-bf59954dd79d@wendy>
Date: Mon, 22 Jul 2024 12:26:55 +0100
From: Conor Dooley <conor.dooley@...rochip.com>
To: Ayush Singh <ayush@...gleboard.org>
CC: Conor Dooley <conor@...nel.org>, <jkridner@...gleboard.org>,
	<robertcnelson@...gleboard.org>, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
	<krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Nishanth Menon
	<nm@...com>, Vignesh Raghavendra <vigneshr@...com>, Tero Kristo
	<kristo@...nel.org>, Johan Hovold <johan@...nel.org>, Alex Elder
	<elder@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<greybus-dev@...ts.linaro.org>, <netdev@...r.kernel.org>,
	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 1/3] dt-bindings: net: ti,cc1352p7: Add boot-gpio

On Mon, Jul 22, 2024 at 04:15:41PM +0530, Ayush Singh wrote:
> 
> On 7/19/24 20:25, Conor Dooley wrote:
> > On Fri, Jul 19, 2024 at 03:15:10PM +0530, Ayush Singh wrote:
> > > boot-gpio (along with reset-gpio) is used to enable bootloader backdoor
> > > for flashing new firmware.
> > > 
> > > The pin and pin level to enabel bootloader backdoor is configed using
> > > the following CCFG variables in cc1352p7:
> > > - SET_CCFG_BL_CONFIG_BL_PIN_NO
> > > - SET_CCFG_BL_CONFIG_BL_LEVEL
> > > 
> > > Signed-off-by: Ayush Singh <ayush@...gleboard.org>
> > > ---
> > >   Documentation/devicetree/bindings/net/ti,cc1352p7.yaml | 4 ++++
> > >   1 file changed, 4 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml b/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml
> > > index 3dde10de4630..a3511bb59b05 100644
> > > --- a/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml
> > > +++ b/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml
> > > @@ -29,6 +29,9 @@ properties:
> > >     reset-gpios:
> > >       maxItems: 1
> > > +  boot-gpios:
> > > +    maxItems: 1
> > I think this needs a description that explains what this is actually
> > for, and "boot-gpios" is not really an accurate name for what it is used
> > for IMO.
> 
> I was using the name `boot-gpios` since cc1352-flasher uses the name
> boot-line. Anyway, would `bsl-gpios` be better?

I dunno, I think that "bsl" is worse.

> Or for more descriptive
> names, I guess it can be `bootloader-config-gpios` or

> `bootloader-backdoor-gpios`.

This is the most descriptive and therefore, IMO, best.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)