[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d0d500cc-6eba-843d-1ca5-ca1e44bd003e@intel.com>
Date: Tue, 23 Jul 2024 15:09:08 -0700
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: Sergey Temerkhanov <sergey.temerkhanov@...el.com>,
<intel-wired-lan@...ts.osuosl.org>
CC: <netdev@...r.kernel.org>, Przemek Kitszel <przemyslaw.kitszel@...el.com>,
Simon Horman <horms@...nel.org>
Subject: Re: [PATCH iwl-next v4 4/5] ice: Use ice_adapter for PTP shared data
instead of auxdev
On 7/18/2024 3:52 AM, Sergey Temerkhanov wrote:
> Use struct ice_adapter to hold shared PTP data and control PTP
> related actions instead of auxbus. This allows significant code
> simplification and faster access to the container fields used in
> the PTP support code.
>
> Move the PTP port list to the ice_adapter container to simplify
> the code and avoid race conditions which could occur due to the
> synchronous nature of the initialization/access and
> certain memory saving can be achieved by moving PTP data into
> the ice_adapter itself.
>
> Signed-off-by: Sergey Temerkhanov <sergey.temerkhanov@...el.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Reviewed-by: Simon Horman <horms@...nel.org>
> ---
...
> @@ -2967,6 +2967,50 @@ void ice_ptp_rebuild(struct ice_pf *pf, enum ice_reset_req reset_type)
> dev_err(ice_pf_to_dev(pf), "PTP reset failed %d\n", err);
> }
>
> +static inline bool ice_is_primary(struct ice_hw *hw)
no 'inline' for c files please.
> +{
> + return ice_is_e825c(hw) && ice_is_dual(hw) ?
> + !!(hw->dev_caps.nac_topo.mode & ICE_NAC_TOPO_PRIMARY_M) : true;
> +}
> +
...
> --- a/drivers/net/ethernet/intel/ice/ice_ptp_hw.h
> +++ b/drivers/net/ethernet/intel/ice/ice_ptp_hw.h
> @@ -468,6 +468,11 @@ static inline u64 ice_get_base_incval(struct ice_hw *hw)
> }
> }
>
> +static inline bool ice_is_dual(struct ice_hw *hw)
> +{
> + return !!(hw->dev_caps.nac_topo.mode & ICE_NAC_TOPO_DUAL_M);
> +}
Please use tabs:
ERROR: code indent should use tabs where possible
#408: FILE: drivers/net/ethernet/intel/ice/ice_ptp_hw.h:473:
+ return !!(hw->dev_caps.nac_topo.mode & ICE_NAC_TOPO_DUAL_M);$
WARNING: please, no spaces at the start of a line
#408: FILE: drivers/net/ethernet/intel/ice/ice_ptp_hw.h:473:
+ return !!(hw->dev_caps.nac_topo.mode & ICE_NAC_TOPO_DUAL_M);$
Thanks,
Tony
> +
> #define PFTSYN_SEM_BYTES 4
>
> #define ICE_PTP_CLOCK_INDEX_0 0x00
Powered by blists - more mailing lists