netdev - RE: [Intel-wired-lan] [iwl-next v5 05/15] ice: allocate devlink for subfunction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ0PR11MB5865EE561C6E01A182BDE2A28FA92@SJ0PR11MB5865.namprd11.prod.outlook.com>
Date: Tue, 23 Jul 2024 11:15:27 +0000
From: "Romanowski, Rafal" <rafal.romanowski@...el.com>
To: Simon Horman <horms@...nel.org>, Michal Swiatkowski
	<michal.swiatkowski@...ux.intel.com>
CC: "shayd@...dia.com" <shayd@...dia.com>, "Fijalkowski, Maciej"
	<maciej.fijalkowski@...el.com>, "Polchlopek, Mateusz"
	<mateusz.polchlopek@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "jiri@...dia.com" <jiri@...dia.com>,
	"kalesh-anakkur.purayil@...adcom.com" <kalesh-anakkur.purayil@...adcom.com>,
	"Kubiak, Michal" <michal.kubiak@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"pio.raczynski@...il.com" <pio.raczynski@...il.com>, "Samudrala, Sridhar"
	<sridhar.samudrala@...el.com>, "Keller, Jacob E" <jacob.e.keller@...el.com>,
	"Drewek, Wojciech" <wojciech.drewek@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>
Subject: RE: [Intel-wired-lan] [iwl-next v5 05/15] ice: allocate devlink for
 subfunction

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Simon
> Horman
> Sent: Friday, June 14, 2024 12:55 PM
> To: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> Cc: shayd@...dia.com; Fijalkowski, Maciej <maciej.fijalkowski@...el.com>;
> Polchlopek, Mateusz <mateusz.polchlopek@...el.com>; netdev@...r.kernel.org;
> jiri@...dia.com; kalesh-anakkur.purayil@...adcom.com; Kubiak, Michal
> <michal.kubiak@...el.com>; intel-wired-lan@...ts.osuosl.org;
> pio.raczynski@...il.com; Samudrala, Sridhar <sridhar.samudrala@...el.com>;
> Keller, Jacob E <jacob.e.keller@...el.com>; Drewek, Wojciech
> <wojciech.drewek@...el.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>
> Subject: Re: [Intel-wired-lan] [iwl-next v5 05/15] ice: allocate devlink for
> subfunction
> 
> On Thu, Jun 06, 2024 at 01:24:53PM +0200, Michal Swiatkowski wrote:
> > From: Piotr Raczynski <piotr.raczynski@...el.com>
> >
> > Make devlink allocation function generic to use it for PF and for SF.
> >
> > Add function for SF devlink port creation. It will be used in next
> > patch.
> >
> > Create header file for subfunction device. Define subfunction device
> > structure there as it is needed for devlink allocation and port
> > creation.
> >
> > Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> > Signed-off-by: Piotr Raczynski <piotr.raczynski@...el.com>
> > Signed-off-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> 
> Thanks Piotr,
> 
> I believe this addresses Jiri's review of v4.
> And the minor nit below not withstanding, this looks good to me.
> 
> Reviewed-by: Simon Horman <horms@...nel.org>
> 
> ...
> 
> > diff --git a/drivers/net/ethernet/intel/ice/devlink/devlink.c
> > b/drivers/net/ethernet/intel/ice/devlink/devlink.c
> 
> ...
> 


Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>