netdev - RE: [Intel-wired-lan] [iwl-next v5 03/15] ice: add basic devlink subfunctions support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ0PR11MB58658B2E963126964A14509F8FA92@SJ0PR11MB5865.namprd11.prod.outlook.com>
Date: Tue, 23 Jul 2024 11:13:59 +0000
From: "Romanowski, Rafal" <rafal.romanowski@...el.com>
To: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "shayd@...dia.com" <shayd@...dia.com>, "Fijalkowski, Maciej"
	<maciej.fijalkowski@...el.com>, "horms@...nel.org" <horms@...nel.org>,
	"Samudrala, Sridhar" <sridhar.samudrala@...el.com>, "Polchlopek, Mateusz"
	<mateusz.polchlopek@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "jiri@...dia.com" <jiri@...dia.com>,
	"kalesh-anakkur.purayil@...adcom.com" <kalesh-anakkur.purayil@...adcom.com>,
	"Kubiak, Michal" <michal.kubiak@...el.com>, "pio.raczynski@...il.com"
	<pio.raczynski@...il.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "Keller, Jacob E" <jacob.e.keller@...el.com>,
	"Drewek, Wojciech" <wojciech.drewek@...el.com>
Subject: RE: [Intel-wired-lan] [iwl-next v5 03/15] ice: add basic devlink
 subfunctions support

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Michal
> Swiatkowski
> Sent: Thursday, June 6, 2024 1:25 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: shayd@...dia.com; Fijalkowski, Maciej <maciej.fijalkowski@...el.com>;
> horms@...nel.org; Samudrala, Sridhar <sridhar.samudrala@...el.com>;
> Polchlopek, Mateusz <mateusz.polchlopek@...el.com>; netdev@...r.kernel.org;
> jiri@...dia.com; kalesh-anakkur.purayil@...adcom.com; Kubiak, Michal
> <michal.kubiak@...el.com>; pio.raczynski@...il.com; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>; Keller, Jacob E <jacob.e.keller@...el.com>;
> Drewek, Wojciech <wojciech.drewek@...el.com>
> Subject: [Intel-wired-lan] [iwl-next v5 03/15] ice: add basic devlink subfunctions
> support
> 
> From: Piotr Raczynski <piotr.raczynski@...el.com>
> 
> Implement devlink port handlers responsible for ethernet type devlink
> subfunctions. Create subfunction devlink port and setup all resources needed for
> a subfunction netdev to operate. Configure new VSI for each new subfunction,
> initialize and configure interrupts and Tx/Rx resources.
> Set correct MAC filters and create new netdev.
> 
> For now, subfunction is limited to only one Tx/Rx queue pair.
> 
> Only allocate new subfunction VSI with devlink port new command.
> Allocate and free subfunction MSIX interrupt vectors using new API calls with
> pci_msix_alloc_irq_at and pci_msix_free_irq.
> 
> Support both automatic and manual subfunction numbers. If no subfunction
> number is provided, use xa_alloc to pick a number automatically. This will find the
> first free index and use that as the number. This reduces burden on users in the
> simple case where a specific number is not required. It may also be slightly faster
> to check that a number exists since xarray lookup should be faster than a linear
> scan of the dyn_ports xarray.
> 
> Reviewed-by: Simon Horman <horms@...nel.org>
> Reviewed-by: Wojciech Drewek <wojciech.drewek@...el.com>
> Co-developed-by: Jacob Keller <jacob.e.keller@...el.com>
> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> Signed-off-by: Piotr Raczynski <piotr.raczynski@...el.com>
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> ---
>  .../net/ethernet/intel/ice/devlink/devlink.c  |   3 +
>  .../ethernet/intel/ice/devlink/devlink_port.c | 288 ++++++++++++++++++
> .../ethernet/intel/ice/devlink/devlink_port.h |  34 +++
>  drivers/net/ethernet/intel/ice/ice.h          |   4 +
>  drivers/net/ethernet/intel/ice/ice_lib.c      |   5 +-
>  drivers/net/ethernet/intel/ice/ice_lib.h      |   2 +
>  drivers/net/ethernet/intel/ice/ice_main.c     |   7 +
>  7 files changed, 341 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/devlink/devlink.c
> b/drivers/net/ethernet/intel/ice/devlink/devlink.c
> index f774781ab514..bfb3d5b59a62 100644
> --- a/drivers/net/ethernet/intel/ice/devlink/devlink.c
> +++ b/drivers/net/ethernet/intel/ice/devlink/devlink.c
> @@ -6,6 +6,7 @@

Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>