netdev - Re: [PATCH bpf] selftests/bpf: Filter out _GNU_SOURCE when compiling test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240726181020.19bca47d@kernel.org>
Date: Fri, 26 Jul 2024 18:10:20 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc: Stanislav Fomichev <sdf@...ichev.me>, bpf@...r.kernel.org,
 netdev@...r.kernel.org, ast@...nel.org, daniel@...earbox.net,
 andrii@...nel.org, martin.lau@...ux.dev, song@...nel.org, yhs@...com,
 john.fastabend@...il.com, kpsingh@...nel.org, haoluo@...gle.com,
 jolsa@...nel.org
Subject: Re: [PATCH bpf] selftests/bpf: Filter out _GNU_SOURCE when
 compiling test_cpp

On Fri, 26 Jul 2024 17:45:06 -0700 Andrii Nakryiko wrote:
> or we could
> 
> #ifndef _GNU_SOURCE
> #define _GNU_SOURCE
> #endif
> 
> (though we have 61 places with that...) so as to not have to update
> every target in Makefile.

AFAIU we have -D_GNU_SOURCE= twice _in the command line args_ :(
One is from the Makefile which now always adds it to CFLAGS,
the other is "built-in" in g++ for some weird reason.

FWIW I have added this patch to the netdev "hack queue" so no
preference any more where the patch lands :)