netdev - Re: [PATCH v1 net] rtnetlink: Don't ignore IFLA_TARGET_NETNSID when ifname is specified in rtnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240726182118.1674906e@kernel.org>
Date: Fri, 26 Jul 2024 18:21:18 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Jiri Pirko
 <jiri@...nulli.us>, Kuniyuki Iwashima <kuni1840@...il.com>,
 <netdev@...r.kernel.org>
Subject: Re: [PATCH v1 net] rtnetlink: Don't ignore IFLA_TARGET_NETNSID when
 ifname is specified in rtnl_dellink().

On Fri, 26 Jul 2024 17:19:53 -0700 Kuniyuki Iwashima wrote:
> The cited commit accidentally replaced tgt_net with net in rtnl_dellink().
> 
> As a result, IFLA_TARGET_NETNSID is ignored if the interface is specified
> with IFLA_IFNAME or IFLA_ALT_IFNAME.
> 
> Let's pass tgt_net to rtnl_dev_get().
> 
> Fixes: cc6090e985d7 ("net: rtnetlink: introduce helper to get net_device instance by ifname")
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>

Reviewed-by: Jakub Kicinski <kuba@...nel.org>