netdev - Re: [PATCH net v2] tcp: Adjust clamping window for applications specifying SO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJ6w9dkfUqKMe1q7uMHv9dF12tOQdxABv+qCqG37oa8uA@mail.gmail.com>
Date: Mon, 29 Jul 2024 18:07:08 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Neal Cardwell <ncardwell@...gle.com>
Cc: Subash Abhinov Kasiviswanathan <quic_subashab@...cinc.com>, soheil@...gle.com, yyd@...gle.com, 
	ycheng@...gle.com, davem@...emloft.net, kuba@...nel.org, 
	netdev@...r.kernel.org, dsahern@...nel.org, pabeni@...hat.com, 
	Sean Tranchetti <quic_stranche@...cinc.com>
Subject: Re: [PATCH net v2] tcp: Adjust clamping window for applications
 specifying SO_RCVBUF

On Mon, Jul 29, 2024 at 5:33 PM Neal Cardwell <ncardwell@...gle.com> wrote:

> I was imagining that the code would not really be in the fast path,
> because it would move to the spot in tcp_measure_rcv_mss() where the
> segment length "len" is greater than icsk->icsk_ack.rcv_mss. I imagine
> that should be rare, and we are already doing a somewhat expensive
> do_div() call there, so I was imagining that the additional cost would
> be relatively rare and small?

Let's see your patch :)

Thanks !