netdev - Re: [PATCH net v2] tcp: Adjust clamping window for applications specifying SO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL+tcoCbo2v-Td=1vLgxLSZ3bj7rnkWkr27yjCiMC4QScQo3jw@mail.gmail.com>
Date: Wed, 14 Aug 2024 10:28:16 +0800
From: Jason Xing <kerneljasonxing@...il.com>
To: Neal Cardwell <ncardwell@...gle.com>
Cc: Eric Dumazet <edumazet@...gle.com>, 
	Subash Abhinov Kasiviswanathan <quic_subashab@...cinc.com>, soheil@...gle.com, yyd@...gle.com, 
	ycheng@...gle.com, davem@...emloft.net, kuba@...nel.org, 
	netdev@...r.kernel.org, dsahern@...nel.org, pabeni@...hat.com, 
	Sean Tranchetti <quic_stranche@...cinc.com>
Subject: Re: [PATCH net v2] tcp: Adjust clamping window for applications
 specifying SO_RCVBUF

Hello Neal,

> > Otherwise, I feel that we send a wrong signal to 'administrators' :
> > "We will maintain code to make sure that wrong sysctls settings were
> > not so wrong."
> >
> > Are you aware of anyone changing net.ipv4.tcp_moderate_rcvbuf for any
> > valid reason ?
>
> No, I'm not aware of any valid reason to disable
> net.ipv4.tcp_moderate_rcvbuf. :-)

I was also curious about why this sysctl knob was useful a long time
ago? I don't see any good in it (for many years, we haven't touched
it, setting it to 1 as default). Since you maintainers don't think
it's a good one, could we mark it as deprecated and remove this
sysctl?

Thanks,
Jason