netdev - Re: [PATCH v4 5/5] wifi: brcmfmac: add flag for random seed during firmware download

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1c1fe7ec-1d6b-46ce-a90d-29ca6be01109@broadcom.com>
Date: Mon, 29 Jul 2024 10:11:50 +0200
From: Arend van Spriel <arend.vanspriel@...adcom.com>
To: Jacobe Zang <jacobe.zang@...ion.com>, robh@...nel.org,
 krzk+dt@...nel.org, heiko@...ech.de, kvalo@...nel.org, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, conor+dt@...nel.org
Cc: efectn@...tonmail.com, dsimic@...jaro.org, jagan@...eble.ai,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
 arend@...adcom.com, linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
 megi@....cz, duoming@....edu.cn, bhelgaas@...gle.com,
 minipli@...ecurity.net, brcm80211@...ts.linux.dev,
 brcm80211-dev-list.pdl@...adcom.com, nick@...das.com
Subject: Re: [PATCH v4 5/5] wifi: brcmfmac: add flag for random seed during
 firmware download

On 7/29/2024 9:01 AM, Jacobe Zang wrote:
> Providing the random seed to firmware was tied to the fact that the
> device has a valid OTP, which worked for some Apple chips. However,
> it turns out the BCM43752 device also needs the random seed in order
> to get firmware running. Suspect it is simply tied to the firmware
> branch used for the device. Introducing a mechanism to allow setting
> it for a device through the device table.

Not exactly what I meant by using my patch "as is". I would have kept 
the two patches separate, but it is not a deal breaker for me.

Regards,
Arend

> Co-developed-by: Ondrej Jirman <megi@....cz>
> Signed-off-by: Ondrej Jirman <megi@....cz>
> Co-developed-by: Arend van Spriel <arend.vanspriel@...adcom.com>
> Signed-off-by: Arend van Spriel <arend.vanspriel@...adcom.com>
> Signed-off-by: Jacobe Zang <jacobe.zang@...ion.com>
> ---
>   .../broadcom/brcm80211/brcmfmac/pcie.c        | 52 ++++++++++++++++---
>   .../broadcom/brcm80211/include/brcm_hw_ids.h  |  2 +
>   2 files changed, 46 insertions(+), 8 deletions(-)