netdev - Re: [PATCH net 3/8] net/mlx5: DR, Fix 'stack guard page was hit' error in dr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <370c4d20-bb83-40f8-bccf-12e0685c07ba@intel.com>
Date: Tue, 30 Jul 2024 11:36:00 +0200
From: Wojciech Drewek <wojciech.drewek@...el.com>
To: Tariq Toukan <tariqt@...dia.com>, "David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "Eric
 Dumazet" <edumazet@...gle.com>
CC: <netdev@...r.kernel.org>, Saeed Mahameed <saeedm@...dia.com>, Gal Pressman
	<gal@...dia.com>, Leon Romanovsky <leonro@...dia.com>, Yevgeny Kliteynik
	<kliteyn@...dia.com>, Alex Vesker <valex@...dia.com>
Subject: Re: [PATCH net 3/8] net/mlx5: DR, Fix 'stack guard page was hit'
 error in dr_rule



On 30.07.2024 08:16, Tariq Toukan wrote:
> From: Yevgeny Kliteynik <kliteyn@...dia.com>
> 
> This patch reduces the size of hw_ste_arr_optimized array that is
> allocated on stack from 640 bytes (5 match STEs + 5 action STES)
> to 448 bytes (2 match STEs + 5 action STES).
> This fixes the 'stack guard page was hit' issue, while still fitting
> majority of the usecases (up to 2 match STEs).
> 
> Signed-off-by: Yevgeny Kliteynik <kliteyn@...dia.com>
> Reviewed-by: Alex Vesker <valex@...dia.com>
> Signed-off-by: Tariq Toukan <tariqt@...dia.com>
> ---

Reviewed-by: Wojciech Drewek <wojciech.drewek@...el.com>

>  drivers/net/ethernet/mellanox/mlx5/core/steering/dr_rule.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_rule.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_rule.c
> index 042ca0349124..d1db04baa1fa 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_rule.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_rule.c
> @@ -7,7 +7,7 @@
>  /* don't try to optimize STE allocation if the stack is too constaraining */
>  #define DR_RULE_MAX_STES_OPTIMIZED 0
>  #else
> -#define DR_RULE_MAX_STES_OPTIMIZED 5
> +#define DR_RULE_MAX_STES_OPTIMIZED 2
>  #endif
>  #define DR_RULE_MAX_STE_CHAIN_OPTIMIZED (DR_RULE_MAX_STES_OPTIMIZED + DR_ACTION_MAX_STES)
>