netdev - Re: [PATCH net 4/8] net/mlx5: Lag, don't use the hardcoded value of the first port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <33be63c5-3746-4008-998b-87b7fda06281@intel.com>
Date: Tue, 30 Jul 2024 11:37:35 +0200
From: Wojciech Drewek <wojciech.drewek@...el.com>
To: Tariq Toukan <tariqt@...dia.com>, "David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "Eric
 Dumazet" <edumazet@...gle.com>
CC: <netdev@...r.kernel.org>, Saeed Mahameed <saeedm@...dia.com>, Gal Pressman
	<gal@...dia.com>, Leon Romanovsky <leonro@...dia.com>, Mark Bloch
	<mbloch@...dia.com>
Subject: Re: [PATCH net 4/8] net/mlx5: Lag, don't use the hardcoded value of
 the first port



On 30.07.2024 08:16, Tariq Toukan wrote:
> From: Mark Bloch <mbloch@...dia.com>
> 
> The cited commit didn't change the body of the loop as it should.
> It shouldn't be using MLX5_LAG_P1.
> 
> Fixes: 7e978e7714d6 ("net/mlx5: Lag, use actual number of lag ports")
> Signed-off-by: Mark Bloch <mbloch@...dia.com>
> Signed-off-by: Tariq Toukan <tariqt@...dia.com>
> ---

Reviewed-by: Wojciech Drewek <wojciech.drewek@...el.com>

>  drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c b/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c
> index d0871c46b8c5..cf8045b92689 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c
> @@ -1538,7 +1538,7 @@ u8 mlx5_lag_get_slave_port(struct mlx5_core_dev *dev,
>  		goto unlock;
>  
>  	for (i = 0; i < ldev->ports; i++) {
> -		if (ldev->pf[MLX5_LAG_P1].netdev == slave) {
> +		if (ldev->pf[i].netdev == slave) {
>  			port = i;
>  			break;
>  		}