netdev - Re: [PATCH net-next 2/2] selftests: net: ksft: support marking tests as disruptive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240729190013.5b0743e7@kernel.org>
Date: Mon, 29 Jul 2024 19:00:13 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Stanislav Fomichev <sdf@...ichev.me>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, Shuah Khan <shuah@...nel.org>, Joe Damato
 <jdamato@...tly.com>, Petr Machata <petrm@...dia.com>,
 linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] selftests: net: ksft: support marking
 tests as disruptive

On Mon, 29 Jul 2024 15:10:42 -0700 Stanislav Fomichev wrote:
> +    parser = argparse.ArgumentParser()
> +    parser.add_argument('--skip-disruptive', default=False, action='store_true', help='skip tests that might be disruptive (e.g. restart the interface)')
> +    global KSFT_ARGS
> +    KSFT_ARGS = parser.parse_args()

We pass all other args via env exports, I think we should stick to
that, it's easier to integrate with external runners.

FWIW Mohsin is also adding VERBOSE=1 this way:
https://lore.kernel.org/all/20240715030723.1768360-1-mohsin.bashr@gmail.com/