netdev - Re: [PATCH net] ethtool: fix argument check in do_srxfh function to prevent segmentation fault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240729190433.06e1bb9f@kernel.org>
Date: Mon, 29 Jul 2024 19:04:33 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: 백광록 <zester926@...il.com>
Cc: netdev@...r.kernel.org, mkubecek@...e.cz, ahmed.zaki@...el.com,
 ecree@...arflare.com
Subject: Re: [PATCH net] ethtool: fix argument check in do_srxfh function to
 prevent segmentation fault

On Sat, 27 Jul 2024 22:39:46 +0900 백광록 wrote:
> Subject: [PATCH net] ethtool: fix argument check in do_srxfh function to  prevent segmentation fault

Patch makes sense, but two nit picks:

 1) please repost with subject:

    [PATCH ethtool v2] ethtool: fix argument check in do_srxfh function to prevent segmentation fault

   this is a user space CLI patch, not a kernel patch hence ethtool not
   net in the brackets.

> Ensure that do_srxfh function in ethtool.c checks for the presence of
> additional arguments when context or xfrm parameter is provided before
> performing strcmp. This prevents segmentation faults caused by missing
> arguments.
> 
> Without this patch, running 'ethtool -X DEVNAME [ context | xfrm ]' without
> additional arguments results in a segmentation fault due to an invalid
> strcmp operation.
> 
> Fixes: f5d55b967e0c ("ethtool: add support for extra RSS contexts and
> RSS steering filters")

 2) Please prevent line wrapping of Fixes tags