netdev - Re: [PATCH can-next 04/21] can: rockchip_canfd: add driver for Rockchip CAN-FD controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240730163439.GA1967603@kernel.org>
Date: Tue, 30 Jul 2024 17:34:39 +0100
From: Simon Horman <horms@...nel.org>
To: Marc Kleine-Budde <mkl@...gutronix.de>
Cc: kernel@...gutronix.de, Vincent Mailhol <mailhol.vincent@...adoo.fr>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Heiko Stuebner <heiko@...ech.de>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Elaine Zhang <zhangqing@...k-chips.com>,
	David Jander <david.jander@...tonic.nl>, linux-can@...r.kernel.org,
	netdev@...r.kernel.org, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH can-next 04/21] can: rockchip_canfd: add driver for
 Rockchip CAN-FD controller

On Mon, Jul 29, 2024 at 03:05:35PM +0200, Marc Kleine-Budde wrote:
> Add driver for the Rockchip CAN-FD controller.
> 
> The IP core on the rk3568v2 SoC has 12 documented errata. Corrections
> for these errata will be added in the upcoming patches.
> 
> Since several workarounds are required for the TX path, only add the
> base driver that only implements the RX path.
> 
> Although the RX path implements CAN-FD support, it's not activated in
> ctrlmode_supported, as the IP core in the rk3568v2 has problems with
> receiving or sending certain CAN-FD frames.
> 
> Signed-off-by: Marc Kleine-Budde <mkl@...gutronix.de>

...

> +static void rkcanfd_get_berr_counter_raw(struct rkcanfd_priv *priv,
> +					 struct can_berr_counter *bec)
> +{
> +	struct can_berr_counter bec_raw;
> +
> +	bec->rxerr = rkcanfd_read(priv, RKCANFD_REG_RXERRORCNT);
> +	bec->txerr = rkcanfd_read(priv, RKCANFD_REG_TXERRORCNT);
> +	bec_raw = *bec;

nit: bec_raw is assigned but otherwise unused
     although this is addressed in patch 15 of this series.

> +}

...