[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20240730200335.GA2059838-robh@kernel.org>
Date: Tue, 30 Jul 2024 14:03:35 -0600
From: Rob Herring <robh@...nel.org>
To: Arınç ÜNAL <arinc.unal@...nc9.com>
Cc: Lorenzo Bianconi <lorenzo@...nel.org>, netdev@...r.kernel.org,
daniel@...rotopia.org, dqfext@...il.com, sean.wang@...iatek.com,
andrew@...n.ch, f.fainelli@...il.com, olteanv@...il.com,
davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com, matthias.bgg@...il.com,
angelogioacchino.delregno@...labora.com,
linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, lorenzo.bianconi83@...il.com,
krzk+dt@...nel.org, conor+dt@...nel.org, devicetree@...r.kernel.org,
upstream@...oha.com
Subject: Re: [PATCH net-next 1/2] dt-bindings: net: dsa: mediatek,mt7530: Add
airoha,en7581-switch
On Tue, Jul 30, 2024 at 11:57:36AM +0300, Arınç ÜNAL wrote:
> On 30/07/2024 10:46, Lorenzo Bianconi wrote:
> > Add documentation for the built-in switch which can be found in the
> > Airoha EN7581 SoC.
> >
> > Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org>
> > ---
> > .../devicetree/bindings/net/dsa/mediatek,mt7530.yaml | 9 ++++++++-
> > 1 file changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> > index 7e405ad96eb2..aa89bc89eb45 100644
> > --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> > +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> > @@ -92,6 +92,10 @@ properties:
> > Built-in switch of the MT7988 SoC
> > const: mediatek,mt7988-switch
> > + - description:
> > + Built-in switch of the Airoha EN7581 SoC
> > + const: airoha,en7581-switch
> > +
> > reg:
> > maxItems: 1
> > @@ -284,7 +288,10 @@ allOf:
> > - if:
> > properties:
> > compatible:
> > - const: mediatek,mt7988-switch
> > + contains:
> > + enum:
> > + - mediatek,mt7988-switch
> > + - airoha,en7581-switch
>
> The compatible string won't be more than one item. So this would be a
> better description:
>
> compatible:
> oneOf:
> - const: mediatek,mt7988-switch
> - const: airoha,en7581-switch
enum, not oneOf+const
Powered by blists - more mailing lists