netdev - Re: [PATCH net 1/4] bonding: implement xfrm state xdo_dev_state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49743cc1e561349040964ea06817d8e3e3b75e01.camel@nvidia.com>
Date: Wed, 31 Jul 2024 06:52:32 +0000
From: Jianbo Liu <jianbol@...dia.com>
To: Tariq Toukan <tariqt@...dia.com>, "liuhangbin@...il.com"
	<liuhangbin@...il.com>
CC: "davem@...emloft.net" <davem@...emloft.net>, Leon Romanovsky
	<leonro@...dia.com>, "andy@...yhouse.net" <andy@...yhouse.net>, Gal Pressman
	<gal@...dia.com>, "jv@...sburgh.net" <jv@...sburgh.net>, "kuba@...nel.org"
	<kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"edumazet@...gle.com" <edumazet@...gle.com>, Saeed Mahameed
	<saeedm@...dia.com>, Cosmin Ratiu <cratiu@...dia.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net 1/4] bonding: implement xfrm state xdo_dev_state_free
 API

On Wed, 2024-07-31 at 11:27 +0800, Hangbin Liu wrote:
> On Mon, Jul 29, 2024 at 03:44:02PM +0300, Tariq Toukan wrote:
> > From: Jianbo Liu <jianbol@...dia.com>
> > 
> > Add this implementation for bonding, so hardware resources can be
> > freed after xfrm state is deleted.
> > 
> > Fixes: 9a5605505d9c ("bonding: Add struct bond_ipesc to manage SA")
> > Signed-off-by: Jianbo Liu <jianbol@...dia.com>
> > Reviewed-by: Cosmin Ratiu <cratiu@...dia.com>
> > Signed-off-by: Tariq Toukan <tariqt@...dia.com>
> > ---
> >  drivers/net/bonding/bond_main.c | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/drivers/net/bonding/bond_main.c
> > b/drivers/net/bonding/bond_main.c
> > index 1cd92c12e782..3b880ff2b82a 100644
> > --- a/drivers/net/bonding/bond_main.c
> > +++ b/drivers/net/bonding/bond_main.c
> > @@ -588,6 +588,15 @@ static void bond_ipsec_del_sa_all(struct
> > bonding *bond)
> >         rcu_read_unlock();
> >  }
> >  
> > +static void bond_ipsec_free_sa(struct xfrm_state *xs)
> > +{
> > +       struct net_device *real_dev = xs->xso.real_dev;
> 
> I think it's also good to check the bond/slave status like
> bond_ipsec_del_sa()
> does, no?

It seems no necessary, but I will try adding. Thanks!

> 
> > +
> > +       if (real_dev && real_dev->xfrmdev_ops &&
> > +           real_dev->xfrmdev_ops->xdo_dev_state_free)
> > +               real_dev->xfrmdev_ops->xdo_dev_state_free(xs);
> > +}
> 
> And we should call this in bond_ipsec_del_sa_all() for each slave.

Yes, it's in the next patch.

> 
> Thanks
> Hangbin
> > +
> >  /**
> >   * bond_ipsec_offload_ok - can this packet use the xfrm hw offload
> >   * @skb: current data packet
> > @@ -632,6 +641,7 @@ static bool bond_ipsec_offload_ok(struct
> > sk_buff *skb, struct xfrm_state *xs)
> >  static const struct xfrmdev_ops bond_xfrmdev_ops = {
> >         .xdo_dev_state_add = bond_ipsec_add_sa,
> >         .xdo_dev_state_delete = bond_ipsec_del_sa,
> > +       .xdo_dev_state_free = bond_ipsec_free_sa,
> >         .xdo_dev_offload_ok = bond_ipsec_offload_ok,
> >  };
> >  #endif /* CONFIG_XFRM_OFFLOAD */
> > -- 
> > 2.44.0
> >