netdev - Re: [PATCH net 2/4] bonding: call xfrm state xdo_dev_state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e10218c925c800de81872b21c8de169efcaf4c7e.camel@nvidia.com>
Date: Wed, 31 Jul 2024 07:08:13 +0000
From: Jianbo Liu <jianbol@...dia.com>
To: Tariq Toukan <tariqt@...dia.com>, "liuhangbin@...il.com"
	<liuhangbin@...il.com>
CC: "davem@...emloft.net" <davem@...emloft.net>, Leon Romanovsky
	<leonro@...dia.com>, "andy@...yhouse.net" <andy@...yhouse.net>, Gal Pressman
	<gal@...dia.com>, "jv@...sburgh.net" <jv@...sburgh.net>, "kuba@...nel.org"
	<kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"edumazet@...gle.com" <edumazet@...gle.com>, Saeed Mahameed
	<saeedm@...dia.com>, Cosmin Ratiu <cratiu@...dia.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net 2/4] bonding: call xfrm state xdo_dev_state_free after
 deletion

On Wed, 2024-07-31 at 11:36 +0800, Hangbin Liu wrote:
> On Mon, Jul 29, 2024 at 03:44:03PM +0300, Tariq Toukan wrote:
> > From: Jianbo Liu <jianbol@...dia.com>
> > 
> > Need to call xdo_dev_state_free API to avoid hardware resource
> > leakage
> > when deleting all SAs from old active real interface.
> > 
> > Fixes: 9a5605505d9c ("bonding: Add struct bond_ipesc to manage SA")
> > Signed-off-by: Jianbo Liu <jianbol@...dia.com>
> > Reviewed-by: Cosmin Ratiu <cratiu@...dia.com>
> > Signed-off-by: Tariq Toukan <tariqt@...dia.com>
> > ---
> >  drivers/net/bonding/bond_main.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/net/bonding/bond_main.c
> > b/drivers/net/bonding/bond_main.c
> > index 3b880ff2b82a..551cebfa3261 100644
> > --- a/drivers/net/bonding/bond_main.c
> > +++ b/drivers/net/bonding/bond_main.c
> > @@ -581,6 +581,8 @@ static void bond_ipsec_del_sa_all(struct
> > bonding *bond)
> >                                    __func__);
> >                 } else {
> >                         slave->dev->xfrmdev_ops-
> > >xdo_dev_state_delete(ipsec->xs);
> > +                       if (slave->dev->xfrmdev_ops-
> > >xdo_dev_state_free)
> > +                               slave->dev->xfrmdev_ops-
> > >xdo_dev_state_free(ipsec->xs);
> 
> OH, you do it here. 
> 

Yes :)

> >                 }
> >                 ipsec->xs->xso.real_dev = NULL;
> 
> I'm not sure if we should make xdo_dev_state_free() rely on
> xdo_dev_state_delete(). In xfrm_state_find() the
> xfrm_dev_state_free()
> is called whatever xfrm_dev_state_delete() is support or not.
> Although
> usually the NIC driver will support the _delete() if the _free()
> supported.
> 

I don't see they rely on each other, so I'd like to keep it as is.

> BTW, For me this patch should merge with Patch 1/4

Will do. Thanks!

> 
> Thanks
> Hangbin