netdev - Re: [RFC PATCH net-next 09/10] net: hibmcge: Add a Makefile and update Kconfig for hibmcge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0fe6e62f-a6cf-4a9d-9ccc-004570c3c46e@huawei.com>
Date: Thu, 1 Aug 2024 20:15:43 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: Andrew Lunn <andrew@...n.ch>
CC: <shaojijie@...wei.com>, <yisen.zhuang@...wei.com>,
	<salil.mehta@...wei.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <horms@...nel.org>,
	<shenjian15@...wei.com>, <wangpeiyang1@...wei.com>, <liuyonglong@...wei.com>,
	<sudongming1@...wei.com>, <xujunsheng@...wei.com>, <shiyongbang@...wei.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH net-next 09/10] net: hibmcge: Add a Makefile and
 update Kconfig for hibmcge


on 2024/8/1 9:13, Andrew Lunn wrote:
> On Wed, Jul 31, 2024 at 05:42:44PM +0800, Jijie Shao wrote:
>> Add a Makefile and update Kconfig to build hibmcge driver.
>>
>> Signed-off-by: Jijie Shao <shaojijie@...wei.com>
>> ---
>>   drivers/net/ethernet/hisilicon/Kconfig          | 17 ++++++++++++++++-
>>   drivers/net/ethernet/hisilicon/Makefile         |  1 +
>>   drivers/net/ethernet/hisilicon/hibmcge/Makefile | 10 ++++++++++
>>   3 files changed, 27 insertions(+), 1 deletion(-)
>>   create mode 100644 drivers/net/ethernet/hisilicon/hibmcge/Makefile
>>
>> diff --git a/drivers/net/ethernet/hisilicon/Kconfig b/drivers/net/ethernet/hisilicon/Kconfig
>> index 3312e1d93c3b..372854d15481 100644
>> --- a/drivers/net/ethernet/hisilicon/Kconfig
>> +++ b/drivers/net/ethernet/hisilicon/Kconfig
>> @@ -7,7 +7,7 @@ config NET_VENDOR_HISILICON
>>   	bool "Hisilicon devices"
>>   	default y
>>   	depends on OF || ACPI
>> -	depends on ARM || ARM64 || COMPILE_TEST
>> +	depends on ARM || ARM64 || COMPILE_TEST || X86_64
> It is normal to have COMPILE_TEST last.

ok，

>
> Any reason this won't work on S390, PowerPC etc?

I have only compiled and tested on arm or x86.
I can't ensure that compile or work ok on other platforms.

>
>> +if ARM || ARM64 || COMPILE_TEST
>> +
> You would normally express this with a depends on.

Sorry, I can't understand how to convert if to depends on?

Thanks，

Jijie shao