[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240801121808.GB10274@breakpoint.cc>
Date: Thu, 1 Aug 2024 14:18:08 +0200
From: Florian Westphal <fw@...len.de>
To: Christian Hopps <chopps@...pps.org>
Cc: devel@...ux-ipsec.org, Steffen Klassert <steffen.klassert@...unet.com>,
netdev@...r.kernel.org, Christian Hopps <chopps@...n.net>
Subject: Re: [PATCH ipsec-next v7 08/16] xfrm: iptfs: add user packet (tunnel
ingress) handling
Christian Hopps <chopps@...pps.org> wrote:
> +static void iptfs_output_queued(struct xfrm_state *x, struct sk_buff_head *list)
> +{
> + struct xfrm_iptfs_data *xtfs = x->mode_data;
> + struct sk_buff *skb, *skb2, **nextp;
> + struct skb_shared_info *shi;
> +
[..]
> + if (skb->dev)
> + XFRM_INC_STATS(dev_net(skb->dev),
> + LINUX_MIB_XFRMOUTERROR);
Nit:
Here and in several places you are using dev_net() helper.
I think that if xfrm_state is available, then xs_net(x) makes more sense.
It also avoids the skb->dev conditional.
Powered by blists - more mailing lists