netdev - Re: [PATCH] net/chelsio/libcxgb: Add __percpu annotations to libcxgb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240731181155.78219465@kernel.org>
Date: Wed, 31 Jul 2024 18:11:55 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Uros Bizjak <ubizjak@...il.com>
Cc: Simon Horman <horms@...nel.org>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH] net/chelsio/libcxgb: Add __percpu annotations to
 libcxgb_ppm.c

On Wed, 31 Jul 2024 12:06:18 +0200 Uros Bizjak wrote:
> > Let's keep to less than 80 columns wide, as is still preferred for
> > Networking code. Perhaps in this case:
> >
> > static struct cxgbi_ppm_pool __percpu *
> > ppm_alloc_cpu_pool(unsigned int *total, unsigned int *pcpu_ppmax)  
> 
> Hm, the original is exactly what sparse dumped, IMO code dumps should
> be left as they were dumped.

Unclear to me what you mean by "dumped" here.
Please follow Simon's advice.
-- 
pw-bot: cr