netdev - Re: [PATCH] net/chelsio/libcxgb: Add __percpu annotations to libcxgb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFULd4YZU2N0ExERf2eb+ELZyWHxAFAG3bRixjeFxKKeb8Te=Q@mail.gmail.com>
Date: Sun, 4 Aug 2024 17:49:58 +0200
From: Uros Bizjak <ubizjak@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Simon Horman <horms@...nel.org>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH] net/chelsio/libcxgb: Add __percpu annotations to libcxgb_ppm.c

On Thu, Aug 1, 2024 at 3:11 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Wed, 31 Jul 2024 12:06:18 +0200 Uros Bizjak wrote:
> > > Let's keep to less than 80 columns wide, as is still preferred for
> > > Networking code. Perhaps in this case:
> > >
> > > static struct cxgbi_ppm_pool __percpu *
> > > ppm_alloc_cpu_pool(unsigned int *total, unsigned int *pcpu_ppmax)
> >
> > Hm, the original is exactly what sparse dumped, IMO code dumps should
> > be left as they were dumped.
>
> Unclear to me what you mean by "dumped" here.
> Please follow Simon's advice.

Oh, sorry, I totally misunderstood Simon's email. I have sent v2 that
includes requested change.

Thanks,
Uros.