netdev - Re: [PATCH net-next v3 5/7] tcp: rstreason: introduce SK_RST_REASON_TCP_KEEPALIVE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL+tcoDpB34ucBe8AH8MAzDv8L-9o_u=Sg=9=rFyuOHP6bduiQ@mail.gmail.com>
Date: Fri, 2 Aug 2024 17:45:36 +0800
From: Jason Xing <kerneljasonxing@...il.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, 
	dsahern@...nel.org, kuniyu@...zon.com, netdev@...r.kernel.org, 
	Jason Xing <kernelxing@...cent.com>
Subject: Re: [PATCH net-next v3 5/7] tcp: rstreason: introduce
 SK_RST_REASON_TCP_KEEPALIVE_TIMEOUT for active reset

Hello Eric,

On Fri, Aug 2, 2024 at 5:35 PM Eric Dumazet <edumazet@...gle.com> wrote:
>
> On Thu, Aug 1, 2024 at 4:55 PM Jason Xing <kerneljasonxing@...il.com> wrote:
> >
> > From: Jason Xing <kernelxing@...cent.com>
> >
> > When we find keepalive timeout here, we should send an RST to the
> > other side.
> >
> > Signed-off-by: Jason Xing <kernelxing@...cent.com>
>
> Note that this changelog does not really match the code.
>
> We were sending an RST already.
>
> Precise changelogs are needed to avoid extra work by stable teams,
> that can 'catch' things based on some keywords, not only Fixes: tags.

Thanks for reminding me. I will revise the changelog.

>
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks!