netdev - Re: [PATCH net-next v3 4/7] tcp: rstreason: introduce SK_RST_REASON_TCP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL+tcoCvMVJLU+1SznRmA8uKtVO=_FH0S9EavU7Y-ffBYu1NjQ@mail.gmail.com>
Date: Fri, 2 Aug 2024 17:49:46 +0800
From: Jason Xing <kerneljasonxing@...il.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, 
	dsahern@...nel.org, kuniyu@...zon.com, netdev@...r.kernel.org, 
	Jason Xing <kernelxing@...cent.com>
Subject: Re: [PATCH net-next v3 4/7] tcp: rstreason: introduce
 SK_RST_REASON_TCP_STATE for active reset

Hello Eric,

On Fri, Aug 2, 2024 at 5:41 PM Eric Dumazet <edumazet@...gle.com> wrote:
>
> On Thu, Aug 1, 2024 at 4:55 PM Jason Xing <kerneljasonxing@...il.com> wrote:
> >
> > From: Jason Xing <kernelxing@...cent.com>
> >
> > Introducing a new type TCP_STATE to handle some reset conditions
> > appearing in RFC 793 due to its socket state. Actually, we can look
> > into RFC 9293 which has no discrepancy about this part.
> >
> > Signed-off-by: Jason Xing <kernelxing@...cent.com>
>
> I really think this SK_RST_REASON_TCP_STATE is weak.
>
> 'Please see RFC 9293' does not help, this RFC has more than 5000 lines in it :/

Yes, there are various reasons and conditions written in RFC 9293
nearly all over the place. I'm unable to conclude and get an union
name. Sorry about that. If I figure out a better name in the future,
I'll let you know.

>
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks for all your help.

Thanks,
Jason