netdev - Re: [PATCH net-next v2 5/5] net: dsa: microchip: check erratum workaround through indirect register read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZqyPaBQoU5XqMt10@pengutronix.de>
Date: Fri, 2 Aug 2024 09:48:56 +0200
From: Oleksij Rempel <o.rempel@...gutronix.de>
To: vtpieter@...il.com
Cc: devicetree@...r.kernel.org, woojung.huh@...rochip.com,
	UNGLinuxDriver@...rochip.com, netdev@...r.kernel.org,
	Pieter Van Trappen <pieter.van.trappen@...n.ch>
Subject: Re: [PATCH net-next v2 5/5] net: dsa: microchip: check erratum
 workaround through indirect register read

Hi Pieter,

On Wed, Jul 31, 2024 at 12:34:03PM +0200, vtpieter@...il.com wrote:
> From: Pieter Van Trappen <pieter.van.trappen@...n.ch>
> 
> Check the erratum workaround application which ensures in addition
> that indirect register write and read work as expected.

> Commit b7fb7729c94f ("net: dsa: microchip: fix register write order in
> ksz8_ind_write8()") would have been found faster like this.

No. It would be not found faster, because there are nearly no active
users/develpers participating in the development/testing of this part of
the driver. I still do not have access to any KSZ879x variant and the
initial erratum fix was done on request without ability to actually
test it on my side. You seems to be the first one for long time making
something for this series :)

The strategy to re-read configs after writing them is also not
consequent in the driver and would not really help here too. It will
show you an error only if the driver is accidentally writing to a
read-only register.

> Also fix the register naming as in the datasheet.
> 
> Signed-off-by: Pieter Van Trappen <pieter.van.trappen@...n.ch>

Nacked-by: Oleksij Rempel <o.rempel@...gutronix.de>

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |