netdev - Re: [PATCH net-next v2 2/5] net: dsa: microchip: move KSZ9477 WoL functions to ksz

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zqxm5NK8JARcgDFE@pengutronix.de>
Date: Fri, 2 Aug 2024 06:56:04 +0200
From: Oleksij Rempel <o.rempel@...gutronix.de>
To: Pieter <vtpieter@...il.com>
Cc: Simon Horman <horms@...nel.org>, devicetree@...r.kernel.org,
	woojung.huh@...rochip.com, UNGLinuxDriver@...rochip.com,
	netdev@...r.kernel.org,
	Pieter Van Trappen <pieter.van.trappen@...n.ch>
Subject: Re: [PATCH net-next v2 2/5] net: dsa: microchip: move KSZ9477 WoL
 functions to ksz_common

Hi Pieter,

On Thu, Aug 01, 2024 at 08:45:03AM +0200, Pieter wrote:
> Le mer. 31 juil. 2024 à 22:10, Simon Horman <horms@...nel.org> a écrit :
> >
> > On Wed, Jul 31, 2024 at 12:34:00PM +0200, vtpieter@...il.com wrote:
> > > From: Pieter Van Trappen <pieter.van.trappen@...n.ch>
> > >
> > > Move KSZ9477 WoL functions to ksz_common, in preparation for adding
> > > KSZ87xx family support.
> > >
> > > Signed-off-by: Pieter Van Trappen <pieter.van.trappen@...n.ch>
> >
> > Hi Pieter,
> >
> > This is not a full review, and I suggest waiting for feedback from others.
> >
> > However, I think this patch-set needs to be re-arranged a little,
> > perhaps by bringing forward some of the header file changes
> > in the following patch forward, either into this patch
> > or a new patch before it.
> 
> Hi Simon, thanks indeed I missed this! It seems difficult to respect both
> patch requirements [1] for this case:
>  * One significant exception is when moving code from one file to another --
>    in this case you should not modify the moved code at all in the same patch
>    which moves it.
> * When dividing your change into a series of patches, take special care to
>   ensure that the kernel builds and runs properly after each patch in
> the series.
> 
> I can make it compile but by moving the code, the KSZ9477 WoL part obviously
> won't run properly anymore. Any suggestion how to tackle this?
> 
> [1] : https://docs.kernel.org/process/submitting-patches.html

I see two options:
1. Add some minimal changes in the header files and describe the changes
in commit message.
2. Do code refactoring which is done in patch 3, before code is moved
around.

In any case, every step should compile.

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |