netdev - Re: [PATCH 1/6] net: driver: stmmac: extend CSR calc support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mn4c5yw3eodduysjaxvt5qpsfm55auumin3jabmu6zymeskdsb@7hvc4qrw6gsn>
Date: Tue, 6 Aug 2024 12:38:17 +0300
From: Serge Semin <fancer.lancer@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: "Jan Petrous (OSS)" <jan.petrous@....nxp.com>, 
	Maxime Coquelin <mcoquelin.stm32@...il.com>, Alexandre Torgue <alexandre.torgue@...s.st.com>, 
	dl-S32 <S32@....com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	"linux-stm32@...md-mailman.stormreply.com" <linux-stm32@...md-mailman.stormreply.com>, 
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, Claudiu Manoil <claudiu.manoil@....com>, 
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH 1/6] net: driver: stmmac: extend CSR calc support

Hi Andrew

On Mon, Aug 05, 2024 at 01:11:16AM +0200, Andrew Lunn wrote:
> >  #define	STMMAC_CSR_20_35M	0x2	/* MDC = clk_scr_i/16 */
> >  #define	STMMAC_CSR_35_60M	0x3	/* MDC = clk_scr_i/26 */
> >  #define	STMMAC_CSR_150_250M	0x4	/* MDC = clk_scr_i/102 */
> > -#define	STMMAC_CSR_250_300M	0x5	/* MDC = clk_scr_i/122 */
> > +#define	STMMAC_CSR_250_300M	0x5	/* MDC = clk_scr_i/124 */
> 
> That should probably be called out in the commit message. It is not a
> fix as such, since it is just a comment, but as a reviewer i had a
> double take when i noticed this.,

Yes, this seems like a typo. I've checked the divider semantic in the DW
GMAC 3.50a/3.73a and DW QoS Eth 5.10a HW databooks. Both of them expect the
clk_scr_i ref clock being divided by 124. So the 122 value was
incorrect.

-Serge(y)

> 
> 
>     Andrew
> 
> ---
> pw-bot: cr
>