netdev - RE: [PATCH 1/6] net: driver: stmmac: extend CSR calc support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <AM9PR04MB85060887C2FB9B397E24231FE2832@AM9PR04MB8506.eurprd04.prod.outlook.com>
Date: Sun, 18 Aug 2024 18:38:35 +0000
From: "Jan Petrous (OSS)" <jan.petrous@....nxp.com>
To: Andrew Lunn <andrew@...n.ch>, "Jan Petrous (OSS)"
	<jan.petrous@....nxp.com>
CC: Maxime Coquelin <mcoquelin.stm32@...il.com>, Alexandre Torgue
	<alexandre.torgue@...s.st.com>, dl-S32 <S32@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-stm32@...md-mailman.stormreply.com"
	<linux-stm32@...md-mailman.stormreply.com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
Subject: RE: [PATCH 1/6] net: driver: stmmac: extend CSR calc support

> -----Original Message-----
> From: Andrew Lunn <andrew@...n.ch>
> Sent: Monday, 5 August, 2024 1:11
> To: Jan Petrous (OSS) <jan.petrous@....nxp.com>
> Cc: Maxime Coquelin <mcoquelin.stm32@...il.com>; Alexandre Torgue
> <alexandre.torgue@...s.st.com>; dl-S32 <S32@....com>; linux-
> kernel@...r.kernel.org; linux-stm32@...md-mailman.stormreply.com; linux-
> arm-kernel@...ts.infradead.org; Claudiu Manoil <claudiu.manoil@....com>;
> netdev@...r.kernel.org
> Subject: Re: [PATCH 1/6] net: driver: stmmac: extend CSR calc support
> 
> >  #define	STMMAC_CSR_20_35M	0x2	/* MDC = clk_scr_i/16 */
> >  #define	STMMAC_CSR_35_60M	0x3	/* MDC = clk_scr_i/26 */
> >  #define	STMMAC_CSR_150_250M	0x4	/* MDC =
> clk_scr_i/102 */
> > -#define	STMMAC_CSR_250_300M	0x5	/* MDC =
> clk_scr_i/122 */
> > +#define	STMMAC_CSR_250_300M	0x5	/* MDC =
> clk_scr_i/124 */
> 
> That should probably be called out in the commit message. It is not a
> fix as such, since it is just a comment, but as a reviewer i had a
> double take when i noticed this.,
> 

Will add the note to the commit message in v2.

/Jan