netdev - Re: [PATCH net-next v4 6/6] net: phy: add Applied Micro QT2025 PHY driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bdfdac7c-edb0-4b78-b616-76be287c7597@lunn.ch>
Date: Sun, 18 Aug 2024 19:39:24 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Benno Lossin <benno.lossin@...ton.me>
Cc: FUJITA Tomonori <fujita.tomonori@...il.com>, netdev@...r.kernel.org,
	rust-for-linux@...r.kernel.org, tmgross@...ch.edu,
	miguel.ojeda.sandonis@...il.com, aliceryhl@...gle.com
Subject: Re: [PATCH net-next v4 6/6] net: phy: add Applied Micro QT2025 PHY
 driver

> Then you get this error:
> 
>     error: unused `core::result::Result` that must be used
>       --> drivers/net/phy/qt2025.rs:88:9
>        |
>     88 |         dev.genphy_read_status::<C45>();
>        |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>        |
>        = note: this `Result` may be an `Err` variant, which should be handled
>        = note: `-D unused-must-use` implied by `-D warnings`
>        = help: to override `-D warnings` add `#[allow(unused_must_use)]`
>     help: use `let _ = ...` to ignore the resulting value
>        |
>     88 |         let _ = dev.genphy_read_status::<C45>();
>        |         +++++++

O.K, so the compiler tells you, which is great. The C compiler would
not, which is why i tend to think of these things.

	Andrew