netdev - Re: [PATCH] net: pse-pd: tps23881: include missing bitfield.h header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZrM6zOyLodtaDVpQ@pengutronix.de>
Date: Wed, 7 Aug 2024 11:13:48 +0200
From: Oleksij Rempel <o.rempel@...gutronix.de>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Kory Maincent <kory.maincent@...tlin.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Kyle Swenson <kyle.swenson@....tech>, Arnd Bergmann <arnd@...db.de>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	Uwe Kleine-König <u.kleine-koenig@...libre.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: pse-pd: tps23881: include missing bitfield.h header

Hi Arnd,

Thank you for your patch.

I acked already other one:
https://lore.kernel.org/all/20240807071538.569784-1-guanjun@linux.alibaba.com/

On Wed, Aug 07, 2024 at 09:54:22AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Using FIELD_GET() fails in configurations that don't already include
> the header file indirectly:
> 
> drivers/net/pse-pd/tps23881.c: In function 'tps23881_i2c_probe':
> drivers/net/pse-pd/tps23881.c:755:13: error: implicit declaration of function 'FIELD_GET' [-Wimplicit-function-declaration]
>   755 |         if (FIELD_GET(TPS23881_REG_DEVID_MASK, ret) != TPS23881_DEVICE_ID) {
>       |             ^~~~~~~~~
> 
> Fixes: 89108cb5c285 ("net: pse-pd: tps23881: Fix the device ID check")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>


Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |