netdev - Re: [PATCH net-next 1/1] net: pse-pd: tps23881: Fix the compiler error about implicit declaration of function ‘FIELD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZrM570f3dUxPm-Bm@pengutronix.de>
Date: Wed, 7 Aug 2024 11:10:07 +0200
From: Oleksij Rempel <o.rempel@...gutronix.de>
To: 'Guanjun' <guanjun@...ux.alibaba.com>
Cc: kyle.swenson@....tech, kory.maincent@...tlin.com, kuba@...nel.org,
	davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
	thomas.petazzoni@...tlin.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/1] net: pse-pd: tps23881: Fix the compiler error about implicit declaration of function ‘FIELD_GET’

On Wed, Aug 07, 2024 at 03:15:38PM +0800, 'Guanjun' wrote:
> From: Guanjun <guanjun@...ux.alibaba.com>
> 
> bitfield.h is not explicitly included but it is required for FIELD_GET.
> There will be a compiler error:
>   drivers/net/pse-pd/tps23881.c: In function ‘tps23881_i2c_probe’:
>   drivers/net/pse-pd/tps23881.c:755:6: error: implicit declaration of function ‘FIELD_GET’ [-Werror=implicit-function-declaration]
>     755 |  if (FIELD_GET(TPS23881_REG_DEVID_MASK, ret) != TPS23881_DEVICE_ID) {
>         |      ^~~~~~~~~
>   cc1: some warnings being treated as errors
> 
> Fixes: 89108cb5c285 (net: pse-pd: tps23881: Fix the device ID check)
> Signed-off-by: Guanjun <guanjun@...ux.alibaba.com>

Acked-by: Oleksij Rempel <o.rempel@...gutronix.de>
Thank you!

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |