netdev - [PATCH net-next 1/1] net: pse-pd: tps23881: Fix the compiler error about implicit declaration of function ‘FIELD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240807071538.569784-1-guanjun@linux.alibaba.com>
Date: Wed,  7 Aug 2024 15:15:38 +0800
From: 'Guanjun' <guanjun@...ux.alibaba.com>
To: kyle.swenson@....tech,
	o.rempel@...gutronix.de,
	kory.maincent@...tlin.com,
	kuba@...nel.org
Cc: davem@...emloft.net,
	edumazet@...gle.com,
	pabeni@...hat.com,
	thomas.petazzoni@...tlin.com,
	netdev@...r.kernel.org,
	guanjun@...ux.alibaba.com
Subject: [PATCH net-next 1/1] net: pse-pd: tps23881: Fix the compiler error about implicit declaration of function ‘FIELD_GET’

From: Guanjun <guanjun@...ux.alibaba.com>

bitfield.h is not explicitly included but it is required for FIELD_GET.
There will be a compiler error:
  drivers/net/pse-pd/tps23881.c: In function ‘tps23881_i2c_probe’:
  drivers/net/pse-pd/tps23881.c:755:6: error: implicit declaration of function ‘FIELD_GET’ [-Werror=implicit-function-declaration]
    755 |  if (FIELD_GET(TPS23881_REG_DEVID_MASK, ret) != TPS23881_DEVICE_ID) {
        |      ^~~~~~~~~
  cc1: some warnings being treated as errors

Fixes: 89108cb5c285 (net: pse-pd: tps23881: Fix the device ID check)
Signed-off-by: Guanjun <guanjun@...ux.alibaba.com>
---
 drivers/net/pse-pd/tps23881.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/pse-pd/tps23881.c b/drivers/net/pse-pd/tps23881.c
index f90db758554b..fa947e30e2ba 100644
--- a/drivers/net/pse-pd/tps23881.c
+++ b/drivers/net/pse-pd/tps23881.c
@@ -10,6 +10,7 @@
 #include <linux/i2c.h>
 #include <linux/module.h>
 #include <linux/of.h>
+#include <linux/bitfield.h>
 #include <linux/platform_device.h>
 #include <linux/pse-pd/pse.h>
 
-- 
2.43.5