netdev - Re: [PATCH net] ethtool: Fix context creation with no parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e5a9000a-230e-4118-8628-b44b682c8d8d@nvidia.com>
Date: Wed, 7 Aug 2024 19:14:57 +0300
From: Gal Pressman <gal@...dia.com>
To: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Dragos Tatulea <dtatulea@...dia.com>,
 Jianbo Liu <jianbol@...dia.com>
Subject: Re: [PATCH net] ethtool: Fix context creation with no parameters

On 07/08/2024 16:25, Gal Pressman wrote:
> diff --git a/net/ethtool/ioctl.c b/net/ethtool/ioctl.c
> index 8ca13208d240..2fdbdcfa1506 100644
> --- a/net/ethtool/ioctl.c
> +++ b/net/ethtool/ioctl.c
> @@ -1372,14 +1372,15 @@ static noinline_for_stack int ethtool_set_rxfh(struct net_device *dev,
>  	/* If either indir, hash key or function is valid, proceed further.

This comment is wrong, the check doesn't really verify the hash function
is valid. I'll remove it in my fix unless you have any objections.

Not verifying the hash function is probably another bug, but it's too
late to fix it at this point?

>  	 * Must request at least one change: indir size, hash key, function
>  	 * or input transformation.
> +	 * There's no need for any of it in case of context creation.
>  	 */