netdev - Re: [PATCH net-next 1/4] igb: prepare for AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bk21hmnl.fsf@kurt.kurt.home>
Date: Fri, 09 Aug 2024 15:05:18 +0200
From: Kurt Kanzenbach <kurt@...utronix.de>
To: Maciej Fijalkowski <maciej.fijalkowski@...el.com>, Tony Nguyen
 <anthony.l.nguyen@...el.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
 edumazet@...gle.com, netdev@...r.kernel.org, Sriram Yagnaraman
 <sriram.yagnaraman@....tech>, magnus.karlsson@...el.com, ast@...nel.org,
 daniel@...earbox.net, hawk@...nel.org, john.fastabend@...il.com,
 bpf@...r.kernel.org, sriram.yagnaraman@...csson.com,
 richardcochran@...il.com, benjamin.steinke@...s-audio.com,
 bigeasy@...utronix.de, Chandan Kumar
 Rout <chandanx.rout@...el.com>
Subject: Re: [PATCH net-next 1/4] igb: prepare for AF_XDP zero-copy support

On Thu Aug 08 2024, Maciej Fijalkowski wrote:
> On Thu, Aug 08, 2024 at 11:35:51AM -0700, Tony Nguyen wrote:
>> From: Sriram Yagnaraman <sriram.yagnaraman@....tech>
>> 
>> Always call igb_xdp_ring_update_tail under __netif_tx_lock, add a
>> comment to indicate that. This is needed to share the same TX ring
>> between XDP, XSK and slow paths.
>
> standalone commit

Ok.

>> +static inline bool igb_xdp_is_enabled(struct igb_adapter *adapter)
>> +{
>> +	return !!adapter->xdp_prog;
>
> READ_ONCE() plus use this everywhere else where prog is read.

Sure. I'll send v6 to iwl then.

Thanks,
Kurt

Download attachment "signature.asc" of type "application/pgp-signature" (862 bytes)