netdev - RE: [PATCH net-next 1/4] igb: prepare for AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA1PR11MB6097C23D38FDAEA5B6A72E3882BA2@IA1PR11MB6097.namprd11.prod.outlook.com>
Date: Fri, 9 Aug 2024 13:14:35 +0000
From: "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>
To: Kurt Kanzenbach <kurt@...utronix.de>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>
CC: "davem@...emloft.net" <davem@...emloft.net>, "kuba@...nel.org"
	<kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, Sriram Yagnaraman <sriram.yagnaraman@....tech>,
	"Karlsson, Magnus" <magnus.karlsson@...el.com>, "ast@...nel.org"
	<ast@...nel.org>, "daniel@...earbox.net" <daniel@...earbox.net>,
	"hawk@...nel.org" <hawk@...nel.org>, "john.fastabend@...il.com"
	<john.fastabend@...il.com>, "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
	"sriram.yagnaraman@...csson.com" <sriram.yagnaraman@...csson.com>,
	"richardcochran@...il.com" <richardcochran@...il.com>,
	"benjamin.steinke@...s-audio.com" <benjamin.steinke@...s-audio.com>,
	"bigeasy@...utronix.de" <bigeasy@...utronix.de>, "Rout, ChandanX"
	<chandanx.rout@...el.com>
Subject: RE: [PATCH net-next 1/4] igb: prepare for AF_XDP zero-copy support

> 
> On Thu Aug 08 2024, Maciej Fijalkowski wrote:
> > On Thu, Aug 08, 2024 at 11:35:51AM -0700, Tony Nguyen wrote:
> >> From: Sriram Yagnaraman <sriram.yagnaraman@....tech>
> >>
> >> Always call igb_xdp_ring_update_tail under __netif_tx_lock, add a
> >> comment to indicate that. This is needed to share the same TX ring
> >> between XDP, XSK and slow paths.
> >
> > standalone commit
> 
> Ok.
> 
> >> +static inline bool igb_xdp_is_enabled(struct igb_adapter *adapter)
> >> +{
> >> +	return !!adapter->xdp_prog;
> >
> > READ_ONCE() plus use this everywhere else where prog is read.
> 
> Sure. I'll send v6 to iwl then.

I'm in the middle of going through rest of the set, will finish today.

> 
> Thanks,
> Kurt