netdev - Re: [PATCH net-next v4 5/5] net: dsa: microchip: apply KSZ87xx family fixes wrt datasheet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <039c9a99c890472bea5ca4e4a8abc0830fe7b607.camel@microchip.com>
Date: Mon, 12 Aug 2024 14:29:49 +0000
From: <Arun.Ramadoss@...rochip.com>
To: <vtpieter@...il.com>
CC: <andrew@...n.ch>, <olteanv@...il.com>, <robh@...nel.org>,
	<Woojung.Huh@...rochip.com>, <pieter.van.trappen@...n.ch>,
	<davem@...emloft.net>, <marex@...x.de>, <conor+dt@...nel.org>,
	<edumazet@...gle.com>, <UNGLinuxDriver@...rochip.com>,
	<devicetree@...r.kernel.org>, <linux@...linux.org.uk>,
	<linux-kernel@...r.kernel.org>, <pabeni@...hat.com>, <krzk+dt@...nel.org>,
	<kuba@...nel.org>, <netdev@...r.kernel.org>, <f.fainelli@...il.com>
Subject: Re: [PATCH net-next v4 5/5] net: dsa: microchip: apply KSZ87xx family
 fixes wrt datasheet

On Mon, 2024-08-12 at 12:55 +0200, Pieter wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> Hi Arun,
> 
> > @@ -141,7 +141,7 @@ static struct sk_buff *ksz8795_rcv(struct
> > sk_buff
> > > *skb, struct net_device *dev)
> > >  {
> > >         u8 *tag = skb_tail_pointer(skb) - KSZ_EGRESS_TAG_LEN;
> > > 
> > > -       return ksz_common_rcv(skb, dev, tag[0] & 7,
> > > KSZ_EGRESS_TAG_LEN);
> > > +       return ksz_common_rcv(skb, dev, tag[0] & 3,
> > > KSZ_EGRESS_TAG_LEN);
> > >  }
> > 
> > This change can be separate patch. since it is not related to
> > ksz87xx_dev_ops structure. Is it a fix or just good to have one. If
> > it
> > is a fix then it should be point to net tree.
> > 
> 
> It's a fix wrt to datasheet but in reality I can see from tests with
> a KSZ8794 that bit 2 is always 0 so the bug doesn't manifest itself.
> 
> Please advise, keep it in net-next or make a separate patch for the
> net tree?

Then it could point to net-next. Keep it as 6th patch of this patch
set. Instead of 3 as magic number, it can be macro.