netdev - Re: [PATCH net] selftest: af_unix: Fix kselftest compilation warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240812183944.59844-1-kuniyu@amazon.com>
Date: Mon, 12 Aug 2024 11:39:44 -0700
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <jain.abhinav177@...il.com>
CC: <davem@...emloft.net>, <edumazet@...gle.com>,
	<javier.carrasco.cruz@...il.com>, <kuba@...nel.org>,
	<linux-kernel@...r.kernel.org>, <linux-kselftest@...r.kernel.org>,
	<netdev@...r.kernel.org>, <pabeni@...hat.com>, <shuah@...nel.org>,
	<skhan@...uxfoundation.org>, <kuniyu@...zon.com>
Subject: Re: [PATCH net] selftest: af_unix: Fix kselftest compilation warnings

From: Abhinav Jain <jain.abhinav177@...il.com>
Date: Sat, 10 Aug 2024 19:10:37 +0530
> Add proper type cast (char *) to the buffer being passed to TH_LOG
> macro in __recvpair function.
> 
> This change fixes the below warnings during test compilation:
> 
> ```
> In file included from msg_oob.c:14:
> msg_oob.c: In function ‘__recvpair’:
> 
> ../../kselftest_harness.h:106:40: warning: format ‘%s’ expects argument
> of type ‘char *’,but argument 6 has type ‘const void *’ [-Wformat=]
> 
> ../../kselftest_harness.h:101:17: note: in expansion of macro ‘__TH_LOG’
> msg_oob.c:235:17: note: in expansion of macro ‘TH_LOG’
> 
> ../../kselftest_harness.h:106:40: warning: format ‘%s’ expects argument
> of type ‘char *’,but argument 6 has type ‘const void *’ [-Wformat=]
> 
> ../../kselftest_harness.h:101:17: note: in expansion of macro ‘__TH_LOG’
> msg_oob.c:259:25: note: in expansion of macro ‘TH_LOG’
> ```
>

Fixes: tag is needed here (no space between SOB tag)

> Signed-off-by: Abhinav Jain <jain.abhinav177@...il.com>
> ---
>  tools/testing/selftests/net/af_unix/msg_oob.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/net/af_unix/msg_oob.c b/tools/testing/selftests/net/af_unix/msg_oob.c
> index 16d0c172eaeb..66d76ab38251 100644
> --- a/tools/testing/selftests/net/af_unix/msg_oob.c
> +++ b/tools/testing/selftests/net/af_unix/msg_oob.c
> @@ -232,7 +232,8 @@ static void __recvpair(struct __test_metadata *_metadata,
>  
>  	if (ret[0] != expected_len || recv_errno[0] != expected_errno) {
>  		TH_LOG("AF_UNIX :%s", ret[0] < 0 ? strerror(recv_errno[0]) : recv_buf[0]);
> -		TH_LOG("Expected:%s", expected_errno ? strerror(expected_errno) : expected_buf);
> +		TH_LOG("Expected:%s",
> +				expected_errno ? strerror(expected_errno) : (char *)expected_buf);
>  
>  		ASSERT_EQ(ret[0], expected_len);
>  		ASSERT_EQ(recv_errno[0], expected_errno);

I don't remember why I defined expected_buf as (void *), but more simple
fix would be the following ?

---8<---
diff --git a/tools/testing/selftests/net/af_unix/msg_oob.c b/tools/testing/selftests/net/af_unix/msg_oob.c
index 16d0c172eaeb..535eb2c3d7d1 100644
--- a/tools/testing/selftests/net/af_unix/msg_oob.c
+++ b/tools/testing/selftests/net/af_unix/msg_oob.c
@@ -209,7 +209,7 @@ static void __sendpair(struct __test_metadata *_metadata,
 
 static void __recvpair(struct __test_metadata *_metadata,
 		       FIXTURE_DATA(msg_oob) *self,
-		       const void *expected_buf, int expected_len,
+		       const char *expected_buf, int expected_len,
 		       int buf_len, int flags)
 {
 	int i, ret[2], recv_errno[2], expected_errno = 0;
---8<---

Thanks!