netdev - Re: [PATCH net] selftest: af_unix: Fix kselftest compilation warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20240812191530.1093038-1-jain.abhinav177@gmail.com>
Date: Tue, 13 Aug 2024 00:45:30 +0530
From: Abhinav Jain <jain.abhinav177@...il.com>
To: kuniyu@...zon.com
Cc: davem@...emloft.net,
	edumazet@...gle.com,
	jain.abhinav177@...il.com,
	javier.carrasco.cruz@...il.com,
	kuba@...nel.org,
	linux-kernel@...r.kernel.org,
	linux-kselftest@...r.kernel.org,
	netdev@...r.kernel.org,
	pabeni@...hat.com,
	shuah@...nel.org,
	skhan@...uxfoundation.org
Subject: Re: [PATCH net] selftest: af_unix: Fix kselftest compilation warnings

On Mon, 12 Aug 2024 11:39:44 -0700, Kuniyuki Iwashima wrote:

> Fixes: tag is needed here (no space between SOB tag)

Thank you, I have added it in v2 here:


> I don't remember why I defined expected_buf as (void *), but more simple
> fix would be the following ?
>
> ---8<---
> diff --git a/tools/testing/selftests/net/af_unix/msg_oob.c b/tools/testing/selftests/net/af_unix/msg_oob.c
> index 16d0c172eaeb..535eb2c3d7d1 100644
> --- a/tools/testing/selftests/net/af_unix/msg_oob.c
> +++ b/tools/testing/selftests/net/af_unix/msg_oob.c
> @@ -209,7 +209,7 @@ static void __sendpair(struct __test_metadata *_metadata,
> 
>  static void __recvpair(struct __test_metadata *_metadata,
>  		       FIXTURE_DATA(msg_oob) *self,
> -		       const void *expected_buf, int expected_len,
> +		       const char *expected_buf, int expected_len,
> 		       int buf_len, int flags)
>  {
> 	int i, ret[2], recv_errno[2], expected_errno = 0;
> ---8<---

Yes, I completely missed that. I have sent a v2, please review:
lore.kernel.org/all/20240812191122.1092806-1-jain.abhinav177@...il.com