netdev - Re: Per-queue stats question

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zr8ZtKXUgUo5OgSK@LQ3V64L9R2.home>
Date: Fri, 16 Aug 2024 10:19:48 +0100
From: Joe Damato <jdamato@...tly.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Edward Cree <ecree.xilinx@...il.com>,
	Network Development <netdev@...r.kernel.org>
Subject: Re: Per-queue stats question

On Thu, Aug 15, 2024 at 12:42:47PM -0700, Jakub Kicinski wrote:
> On Thu, 15 Aug 2024 18:11:42 +0100 Edward Cree wrote:
[...]
> > On a related note, I notice that the stat_cmp() function within that
> >  selftest returns the first nonzero delta it finds in the stats, so
> >  that if (say) tx-packets goes forwards but rx-packets goes backwards,
> >  it will return >0 causing the rx-packets delta to be ignored.  Is
> >  this intended behaviour, or should I submit a patch?
> 
> Looks like a bug.

FWIW, while debugging the stats stuff on mlx5, I tweaked the
stat_cmp function to output a lot more information about each of the
values to help me debug.

It seemed too verbose for an upstream patch at the time, but since
you are going through the same process a patch might make a lot of
sense.