netdev - Re: [PATCH xfrm-next] xfrm: Remove documentation WARN_ON to limit return values for offloaded SA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zr8accEhmBXmaJ87@gauss3.secunet.de>
Date: Fri, 16 Aug 2024 11:22:57 +0200
From: Steffen Klassert <steffen.klassert@...unet.com>
To: Leon Romanovsky <leon@...nel.org>
CC: Patrisious Haddad <phaddad@...dia.com>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Herbert Xu
	<herbert@...dor.apana.org.au>, Jakub Kicinski <kuba@...nel.org>,
	<netdev@...r.kernel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH xfrm-next] xfrm: Remove documentation WARN_ON to limit
 return values for offloaded SA

On Sun, Aug 11, 2024 at 11:56:42AM +0300, Leon Romanovsky wrote:
> From: Patrisious Haddad <phaddad@...dia.com>
> 
> The original idea to put WARN_ON() on return value from driver code was
> to make sure that packet offload doesn't have silent fallback to
> SW implementation, like crypto offload has.
> 
> In reality, this is not needed as all *swan implementations followed
> this request and used explicit configuration style to make sure that
> "users will get what they ask".
> So instead of forcing drivers to make sure that even their internal flows
> don't return -EOPNOTSUPP, let's remove this WARN_ON.
> 
> Signed-off-by: Patrisious Haddad <phaddad@...dia.com>
> Signed-off-by: Leon Romanovsky <leonro@...dia.com>

Applied, thanks a lot!