netdev - Re: [PATCH net-next v6 09/14] net: ethernet: oa_tc6: implement transmit path to transfer tx ethernet frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240816095519.57b470b8@kernel.org>
Date: Fri, 16 Aug 2024 09:55:19 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Parthiban Veerasooran <Parthiban.Veerasooran@...rochip.com>
Cc: <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
 <horms@...nel.org>, <saeedm@...dia.com>, <anthony.l.nguyen@...el.com>,
 <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <andrew@...n.ch>,
 <corbet@....net>, <linux-doc@...r.kernel.org>, <robh+dt@...nel.org>,
 <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
 <devicetree@...r.kernel.org>, <horatiu.vultur@...rochip.com>,
 <ruanjinjie@...wei.com>, <steen.hegelund@...rochip.com>,
 <vladimir.oltean@....com>, <masahiroy@...nel.org>, <alexanderduyck@...com>,
 <krzk+dt@...nel.org>, <robh@...nel.org>, <rdunlap@...radead.org>,
 <hkallweit1@...il.com>, <linux@...linux.org.uk>,
 <UNGLinuxDriver@...rochip.com>, <Thorsten.Kummermehr@...rochip.com>,
 <Pier.Beruto@...emi.com>, <Selvamani.Rajagopal@...emi.com>,
 <Nicolas.Ferre@...rochip.com>, <benjamin.bigler@...nformulastudent.ch>,
 <linux@...ler.io>, <markku.vorne@...power.com>
Subject: Re: [PATCH net-next v6 09/14] net: ethernet: oa_tc6: implement
 transmit path to transfer tx ethernet frames

On Mon, 12 Aug 2024 15:56:06 +0530 Parthiban Veerasooran wrote:
> +		if (skb_queue_len(&tc6->tx_skb_q) < OA_TC6_TX_SKB_QUEUE_SIZE &&
> +		    netif_queue_stopped(tc6->netdev))
> +			netif_wake_queue(tc6->netdev);

FWIW I'm not sure you actually need a queue in the driver.
"A queue of 1" may be enough, IIUC calling netif_wake_queue()
will cause something like an interrupt to fire immediately,
and start_xmit for the next frame should get called before
netif_wake_queue() returns. I could be wrong :)