netdev - Re: [PATCH net-next v3 4/6] rust: net::phy unified read/write API for C22 and C45 registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240816.052721.12647889619015306.fujita.tomonori@gmail.com>
Date: Fri, 16 Aug 2024 05:27:21 +0000 (UTC)
From: FUJITA Tomonori <fujita.tomonori@...il.com>
To: andrew@...n.ch
Cc: fujita.tomonori@...il.com, netdev@...r.kernel.org,
 rust-for-linux@...r.kernel.org, tmgross@...ch.edu,
 miguel.ojeda.sandonis@...il.com, benno.lossin@...ton.me,
 aliceryhl@...gle.com
Subject: Re: [PATCH net-next v3 4/6] rust: net::phy unified read/write API
 for C22 and C45 registers

On Fri, 16 Aug 2024 03:09:31 +0200
Andrew Lunn <andrew@...n.ch> wrote:

> So the problem is with the comment above. It would be better to say
> something like:
> 
> This module provides support for accessing PHY registers in the
> Ethernet management interface clauses 22 and 45 register namespaces, as
> defined in IEEE 802.3.
> 
> Dropping the via, and adding register namespace should make it clear
> we are talking about the registers themselves, not how you access
> them.

Makes sense. Replaced that comment with your version.

Thanks a lot!