netdev - Re: [PATCH net-next v3 5/6] rust: net::phy unified genphy_read_status function for C22 and C45 registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240816.053009.1420518753499945384.fujita.tomonori@gmail.com>
Date: Fri, 16 Aug 2024 05:30:09 +0000 (UTC)
From: FUJITA Tomonori <fujita.tomonori@...il.com>
To: andrew@...n.ch
Cc: fujita.tomonori@...il.com, netdev@...r.kernel.org,
 rust-for-linux@...r.kernel.org, tmgross@...ch.edu,
 miguel.ojeda.sandonis@...il.com, benno.lossin@...ton.me,
 aliceryhl@...gle.com
Subject: Re: [PATCH net-next v3 5/6] rust: net::phy unified
 genphy_read_status function for C22 and C45 registers

On Fri, 16 Aug 2024 03:19:51 +0200
Andrew Lunn <andrew@...n.ch> wrote:

>> +///
>> +///     // Checks the link status and updates current link state via C22.
>> +///     dev.genphy_read_status::<phy::C22>();
>> +///     // Checks the link status and updates current link state via C45.
>> +///     dev.genphy_read_status::<phy::C45>();
> 
> Again, the word `via` is wrong here. You are looking at the link state
> as reported by registers in the C22 namespace, or the C45 namespace.

Yeah, how about the followings?

///     // Checks the link status as reported by registers in the C22 namespace
///     // and updates current link state.
///     dev.genphy_read_status::<phy::C22>();
///     // Checks the link status as reported by registers in the C45 namespace
///     // and updates current link state.
///     dev.genphy_read_status::<phy::C45>();