netdev - Re: [PATCH net-next v5 3/6] rust: net::phy implement AsRef<kernel::device::Device> trait

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240819.124152.1149996909347890108.fujita.tomonori@gmail.com>
Date: Mon, 19 Aug 2024 12:41:52 +0000 (UTC)
From: FUJITA Tomonori <fujita.tomonori@...il.com>
To: tmgross@...ch.edu
Cc: fujita.tomonori@...il.com, netdev@...r.kernel.org,
 rust-for-linux@...r.kernel.org, andrew@...n.ch,
 miguel.ojeda.sandonis@...il.com, benno.lossin@...ton.me,
 aliceryhl@...gle.com
Subject: Re: [PATCH net-next v5 3/6] rust: net::phy implement
 AsRef<kernel::device::Device> trait

On Mon, 19 Aug 2024 02:21:03 -0500
Trevor Gross <tmgross@...ch.edu> wrote:

>> @@ -76,9 +76,11 @@ impl Device {
>>      ///
>>      /// # Safety
>>      ///
>> -    /// For the duration of 'a, the pointer must point at a valid `phy_device`,
>> -    /// and the caller must be in a context where all methods defined on this struct
>> -    /// are safe to call.
>> +    /// For the duration of 'a,
> 
> Nit, backticks around `'a`

Oops, I'll add.

>> +    /// - the pointer must point at a valid `phy_device`, and the caller
>> +    ///   must be in a context where all methods defined on this struct
>> +    ///   are safe to call.
>> +    /// - `(*ptr).mdio.dev` must be a valid.
>>      unsafe fn from_raw<'a>(ptr: *mut bindings::phy_device) -> &'a mut Self {
>>          // CAST: `Self` is a `repr(transparent)` wrapper around `bindings::phy_device`.
>>          let ptr = ptr.cast::<Self>();
> 
> Reviewed-by: Trevor Gross <tmgross@...ch.edu>

Thanks!