netdev - Re: [PATCH net-next 2/2] appletalk: tashtalk: Add LocalTalk line discipline driver for AppleTalk using a TashTalk adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <66CC3DF2-3877-4E59-924A-FA0B14AD4F46@xhero.org>
Date: Mon, 19 Aug 2024 14:39:49 +0200
From: Rodolfo Zitellini <rwz@...ro.org>
To: Arnd Bergmann <arnd@...db.de>
Cc: "David S . Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>,
 Jonathan Corbet <corbet@....net>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Jiri Slaby <jirislaby@...nel.org>,
 Netdev <netdev@...r.kernel.org>,
 linux-doc@...r.kernel.org,
 linux-serial@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 Doug Brown <doug@...morgal.com>
Subject: Re: [PATCH net-next 2/2] appletalk: tashtalk: Add LocalTalk line
 discipline driver for AppleTalk using a TashTalk adapter

> On August 19, 2024, at 11:44 AM, Arnd Bergmann <arnd@...db.de <mailto:arnd@...db.de>> wrote:
> Nice to see you got this into a working state! I vaguely
> remember discussing this in the past, and suggesting you
> try a user space solution,

Hi Arnd, Simon and Jiri,
First and foremost, thank you so much for taking the time to review my code
and for providing your comments.
I will do my best to address the issues and improve the code for the
next submission.

I will also add a longer description on why I went this route, it is mostly
due to compatibility with existing distributions of netatalk 2, which can
work without modification.

> As we discussed in the past, I think this really should
> not use ndo_do_ioctl(), which instead should just disappear.

I will fix this in the next revision, I was not sure if I should touch the
appletalk code for my first submission, but I can add a third patch that
takes care of this.

Kind Regards,
Rodolfo