netdev - Re: [PATCH net-next 2/2] net: dsa: microchip: add KSZ8 change_tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHvy4AqMM74ObHwP9cc57AgGdaxkTWMkZLenPftfrnHzYeUa-A@mail.gmail.com>
Date: Mon, 19 Aug 2024 16:59:01 +0200
From: Pieter <vtpieter@...il.com>
To: Vladimir Oltean <olteanv@...il.com>
Cc: Andrew Lunn <andrew@...n.ch>, Woojung Huh <woojung.huh@...rochip.com>, 
	UNGLinuxDriver@...rochip.com, Florian Fainelli <f.fainelli@...il.com>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Russell King <linux@...linux.org.uk>, Pieter Van Trappen <pieter.van.trappen@...n.ch>, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] net: dsa: microchip: add KSZ8
 change_tag_protocol support

Hi Vladimir,

> > It works as you said, I will have to do some changes to userspace to
> > ensure the DHCP client uses br0 instead of eth0 but that's it.
> > I just tried and br0 obtains the IP address and all is good, with
> > DSA tagging enabled.
> >
> > This patch can be dropped, sorry for the hassle.
>
> I'm pretty baffled. Was this unclear from the user documentation at:
> https://www.kernel.org/doc/html/next/networking/dsa/configuration.html
> ? Maybe we should change something to make it more clear that this is
> what is expected.

It was to me but that's rather due to my limited knowledge of the network
stack and routing than to the quality of that documentation per se.

Cheers, Pieter