netdev - Re: [PATCH net-next v4] l2tp: use skb_queue_purge in l2tp_ip_destroy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+rxrBX7n6YkukO+2KfXDCudvETQ6fesLXR=yimZX19gg@mail.gmail.com>
Date: Mon, 19 Aug 2024 17:00:03 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: James Chapman <jchapman@...alix.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org, 
	pabeni@...hat.com, dsahern@...nel.org, tparkin@...alix.com, 
	xiyou.wangcong@...il.com
Subject: Re: [PATCH net-next v4] l2tp: use skb_queue_purge in l2tp_ip_destroy_sock

On Mon, Aug 19, 2024 at 4:33 PM James Chapman <jchapman@...alix.com> wrote:
>
> Recent commit ed8ebee6def7 ("l2tp: have l2tp_ip_destroy_sock use
> ip_flush_pending_frames") was incorrect in that l2tp_ip does not use
> socket cork and ip_flush_pending_frames is for sockets that do. Use
> __skb_queue_purge instead and remove the unnecessary lock.
>
> Also unexport ip_flush_pending_frames since it was originally exported
> in commit 4ff8863419cd ("ipv4: export ip_flush_pending_frames") for
> l2tp and is not used by other modules.
>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>