netdev - [PATCH net-next v4 2/2] net: dsa: microchip: Add KSZ8895/KSZ8864 switch support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240821110226.1899167-1-vtpieter@gmail.com>
Date: Wed, 21 Aug 2024 13:02:26 +0200
From: vtpieter@...il.com
To: pabeni@...hat.com
Cc: Tristram.Ha@...rochip.com,
	UNGLinuxDriver@...rochip.com,
	andrew@...n.ch,
	conor+dt@...nel.org,
	davem@...emloft.net,
	devicetree@...r.kernel.org,
	edumazet@...gle.com,
	f.fainelli@...il.com,
	krzk+dt@...nel.org,
	kuba@...nel.org,
	linux-kernel@...r.kernel.org,
	marex@...x.de,
	netdev@...r.kernel.org,
	o.rempel@...gutronix.de,
	olteanv@...il.com,
	robh@...nel.org,
	woojung.huh@...rochip.com
Subject: [PATCH net-next v4 2/2] net: dsa: microchip: Add KSZ8895/KSZ8864 switch support

Hi Tristram,

> @@ -325,7 +327,7 @@ void ksz8_r_mib_pkt(struct ksz_device *dev, int port, u16 addr,
>
>  void ksz8_freeze_mib(struct ksz_device *dev, int port, bool freeze)
>  {
> -	if (ksz_is_ksz88x3(dev))
> +	if (ksz_is_ksz88x3(dev) || ksz_is_8895_family(dev))

Small comment, would it not be more clear and consistent to introduce
a new ksz_is_ksz88xx function in ksz_common.h, being ksz_is_ksz88x3 ||
ksz_is_8895_family?

That would help with the renamed ksz88x3_dev_ops that you will
encounter when rebasing. In fact, seeing your additions here, I would
propose to rename this struct to ksz88xx_dev_ops.

Cheers, Pieter