[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aee5b633-31ce-4db0-9014-90f877a33cf4@kernel.org>
Date: Wed, 21 Aug 2024 14:27:46 +0300
From: Roger Quadros <rogerq@...nel.org>
To: MD Danish Anwar <danishanwar@...com>,
Dan Carpenter <dan.carpenter@...aro.org>, Andrew Lunn <andrew@...n.ch>,
Jan Kiszka <jan.kiszka@...mens.com>, Vignesh Raghavendra <vigneshr@...com>,
Javier Carrasco <javier.carrasco.cruz@...il.com>,
Jacob Keller <jacob.e.keller@...el.com>, Diogo Ivo <diogo.ivo@...mens.com>,
Simon Horman <horms@...nel.org>, Richard Cochran <richardcochran@...il.com>,
Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>,
Eric Dumazet <edumazet@...gle.com>, "David S. Miller" <davem@...emloft.net>
Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, srk@...com
Subject: Re: [PATCH net-next v2 1/7] net: ti: icssg-prueth: Enable IEP1
Hi,
On 13/08/2024 10:42, MD Danish Anwar wrote:
> IEP1 is needed by firmware to enable FDB learning and FDB ageing.
Required by which firmware?
Does dual-emac firmware need this?
> Always enable IEP1
>
> Signed-off-by: MD Danish Anwar <danishanwar@...com>
> ---
> drivers/net/ethernet/ti/icssg/icssg_prueth.c | 14 ++++----------
> 1 file changed, 4 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.c b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
> index 53a3e44b99a2..613bd8de6eb8 100644
> --- a/drivers/net/ethernet/ti/icssg/icssg_prueth.c
> +++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
> @@ -1256,12 +1256,8 @@ static int prueth_probe(struct platform_device *pdev)
> goto put_iep0;
> }
>
> - if (prueth->pdata.quirk_10m_link_issue) {
> - /* Enable IEP1 for FW in 64bit mode as W/A for 10M FD link detect issue under TX
> - * traffic.
> - */
> - icss_iep_init_fw(prueth->iep1);
> - }
> + /* Enable IEP1 for FW as it's needed by FW for FDB Learning and FDB ageing */
> + icss_iep_init_fw(prueth->iep1);
>
> /* setup netdev interfaces */
> if (eth0_node) {
> @@ -1366,8 +1362,7 @@ static int prueth_probe(struct platform_device *pdev)
> }
>
> exit_iep:
> - if (prueth->pdata.quirk_10m_link_issue)
> - icss_iep_exit_fw(prueth->iep1);
> + icss_iep_exit_fw(prueth->iep1);
> icss_iep_put(prueth->iep1);
>
> put_iep0:
> @@ -1424,8 +1419,7 @@ static void prueth_remove(struct platform_device *pdev)
> prueth_netdev_exit(prueth, eth_node);
> }
>
> - if (prueth->pdata.quirk_10m_link_issue)
> - icss_iep_exit_fw(prueth->iep1);
> + icss_iep_exit_fw(prueth->iep1);
>
> icss_iep_put(prueth->iep1);
> icss_iep_put(prueth->iep0);
--
cheers,
-roger
Powered by blists - more mailing lists