[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <8316e533-241a-49ef-aac1-07ff01bf489f@wanadoo.fr>
Date: Wed, 21 Aug 2024 11:38:31 +0200
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: Yu Jiaoliang <yujiaoliang@...o.com>,
Johannes Berg <johannes@...solutions.net>,
"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Cc: opensource.kernel@...o.com
Subject: Re: [PATCH v1] net: wireless: Use kmemdup_array instead of kmemdup
for multiple allocation
Le 21/08/2024 à 09:24, Yu Jiaoliang a écrit :
> Let the kememdup_array() take care about multiplication and possible
> overflows.
>
> Signed-off-by: Yu Jiaoliang <yujiaoliang@...o.com>
> ---
> net/wireless/util.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/wireless/util.c b/net/wireless/util.c
> index 9a7c3adc8a3b..6cf19dda5d2a 100644
> --- a/net/wireless/util.c
> +++ b/net/wireless/util.c
> @@ -2435,8 +2435,8 @@ int cfg80211_iter_combinations(struct wiphy *wiphy,
> if (params->num_different_channels > c->num_different_channels)
> continue;
>
> - limits = kmemdup(c->limits, sizeof(limits[0]) * c->n_limits,
> - GFP_KERNEL);
> + limits = kmemdup_array(c->limits, c->n_limits, sizeof(limits[0]),
Maybe sizeof(*limits) would be a more usual pattern?
CJ
> + GFP_KERNEL);
> if (!limits)
> return -ENOMEM;
>
Powered by blists - more mailing lists