netdev - Re: [PATCH V2 net-next 11/11] net: add is_valid_ether_addr check in dev_set_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5948f3f7-a43c-4238-82ff-2806a5ef5975@lunn.ch>
Date: Wed, 21 Aug 2024 14:15:19 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Jijie Shao <shaojijie@...wei.com>
Cc: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net,
	edumazet@...gle.com, pabeni@...hat.com, shenjian15@...wei.com,
	wangpeiyang1@...wei.com, liuyonglong@...wei.com,
	sudongming1@...wei.com, xujunsheng@...wei.com,
	shiyongbang@...wei.com, libaihan@...wei.com, jdamato@...tly.com,
	horms@...nel.org, jonathan.cameron@...wei.com,
	shameerali.kolothum.thodi@...wei.com, salil.mehta@...wei.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 net-next 11/11] net: add is_valid_ether_addr check in
 dev_set_mac_address

On Wed, Aug 21, 2024 at 02:04:01PM +0800, Jijie Shao wrote:
> 
> on 2024/8/21 9:55, Jakub Kicinski wrote:
> > On Tue, 20 Aug 2024 22:01:54 +0800 Jijie Shao wrote:
> > > core need test the mac_addr not every driver need to do.
> > > 
> > > Signed-off-by: Jijie Shao <shaojijie@...wei.com>
> > > ---
> > >   net/core/dev.c | 2 ++
> > >   1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/net/core/dev.c b/net/core/dev.c
> > > index e7260889d4cb..2e19712184bc 100644
> > > --- a/net/core/dev.c
> > > +++ b/net/core/dev.c
> > > @@ -9087,6 +9087,8 @@ int dev_set_mac_address(struct net_device *dev, struct sockaddr *sa,
> > >   		return -EOPNOTSUPP;
> > >   	if (sa->sa_family != dev->type)
> > >   		return -EINVAL;
> > > +	if (!is_valid_ether_addr(sa->sa_data))
> > > +		return -EADDRNOTAVAIL;
> > not every netdev is for an Ethernet device
> 
> ok， this patch will be removed in v3.
> and the check will move to hibmcge driver.

No, you just need to use the correct function to perform the check.

__dev_open() does:

        if (ops->ndo_validate_addr)
                ret = ops->ndo_validate_addr(dev);

	Andrew